git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: js/drop-mingw-test-cmp, was Re: What's cooking in git.git (Dec 2022, #03; Sun, 11)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 20, 2022, 22:59 UTC
Message-ID
<c57ecd23-7ca7-2501-983f-6661c7872a01@gmx.de>
In-Reply-To
<xmqqa63ss3fl.fsf@gitster.g>
Hi Junio,
On Tue, 13 Dec 2022, Junio C Hamano wrote:
Show 9 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > There is a new iteration available here:
> > https://lore.kernel.org/git/pull.1309.v5.git.1670339267.gitgitgadget@gmail.com/
>
> Thanks.
>
> IIRC the review comments hinted that MinGW specific test_cmp that
> equates CRLF and LF are no longer needed,

That does not match my understanding. The MSYS2 tools we use in Git for Windows' SDK (and therefore, in the `win` jobs of our CI runs) are outside of our control, and have been known to change behavior with regards to line endings.

If we want to have a robust experience, we will need to continue that `test_cmp` practice that ignores line endings-only differences.

Ciao, Johannes

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 11 in “What's cooking in git.git (Dec 2022, #03; Sun, 11)”
  1. Junio C HamanoDec 11, 2022
  2. js/drop-mingw-test-cmp, was Re: What's cooking in git.git (Dec 2022, #03; Sun, 11)Johannes Schindelin, Dec 12, 2022
  3. Junio C HamanoDec 12, 2022
  4. Johannes SchindelinDec 20, 2022
  5. Junio C HamanoDec 21, 2022
  6. Johannes SixtDec 24, 2022
  7. René ScharfeDec 24, 2022
  8. Junio C HamanoDec 25, 2022
  9. Johannes SixtDec 25, 2022
  10. René ScharfeDec 26, 2022
  11. Junio C HamanoDec 27, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.