From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 20 Dec 2022 22:59:32 GMT
Subject: Re: js/drop-mingw-test-cmp, was Re: What's cooking in git.git (Dec 2022, #03; Sun, 11)
Message-ID: <c57ecd23-7ca7-2501-983f-6661c7872a01@gmx.de>
In-Reply-To: <xmqqa63ss3fl.fsf@gitster.g>

Hi Junio,

On Tue, 13 Dec 2022, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > There is a new iteration available here:
> > https://lore.kernel.org/git/pull.1309.v5.git.1670339267.gitgitgadget@gmail.com/
>
> Thanks.
>
> IIRC the review comments hinted that MinGW specific test_cmp that
> equates CRLF and LF are no longer needed,

That does not match my understanding. The MSYS2 tools we use in Git for
Windows' SDK (and therefore, in the `win` jobs of our CI runs) are outside
of our control, and have been known to change behavior with regards to
line endings.

If we want to have a robust experience, we will need to continue that
`test_cmp` practice that ignores line endings-only differences.

Ciao,
Johannes