Re: js/drop-mingw-test-cmp, was Re: What's cooking in git.git (Dec 2022, #03; Sun, 11)

From: Johannes Sixt <j6t@kdbg.org>
Date: Dec 24, 2022, 08:10 UTC
Message-ID: <3c55ac67-5090-b7af-a212-2996bad66fb2@kdbg.org>
In-Reply-To: <xmqq7cyksy88.fsf@gitster.g>

Am 21.12.22 um 14:05 schrieb Junio C Hamano:

> I know we have been operating under such a test environment, but
> after seeing the exchange between Réne and J6t, I was hoping that we
> do not have to keep being sloppy.

Things did not turn out to be as simple. After ripping out all special-casing of GIT_TEST_CMP from a MinGW build, I notice at least one case that needs special treatment (it's `tar tf` that writes CRLF output). On top of that, there are prerequisites SED_STRIPS_CR, GREP_STRIPS_CR and perhaps NATIVE_CRLF that should be reconsidered.

For the time being, I suggest to take Dscho's patch.

-- Hannes