[PATCH v5 5/5] branch: avoid unnecessary worktrees traversals
- From
Rubén Justo <rjusto@gmail.com>
- Date
- Mar 26, 2023, 22:33 UTC
- Message-ID
- <c54e35a5-3887-9192-0c9d-8673feaa10ba@gmail.com>
- In-Reply-To
- <f8e6447e-5cd3-98fa-f567-39e1c60dacb0@gmail.com>
When we rename a branch ref, we need to update any worktree that have its HEAD pointing to the branch ref being renamed, so to make it use the new ref name.
If we know in advance that we're renaming a branch that is not currently checked out in any worktree, we can skip this step entirely. Let's do it so.
Signed-off-by: Rubén Justo <rjusto@gmail.com> --- builtin/branch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/branch.c b/builtin/branch.c index a93b9fc0ab..6a564b22b0 100644 --- a/builtin/branch.c +++ b/builtin/branch.c @@ -617,7 +617,7 @@ static void copy_or_rename_branch(const char *oldname, const char *newname, int interpreted_oldname); } - if (!copy && + if (!copy && (oldref_usage & IS_HEAD) && replace_each_worktree_head_symref(worktrees, oldref.buf, newref.buf, logmsg.buf)) die(_("Branch renamed to %s, but HEAD is not updated!"), newname);
-- 2.39.2