[PATCH v2 2/3] branch: description for orphan branch errors
- From
Rubén Justo <rjusto@gmail.com>
- Date
- Jan 16, 2023, 00:02 UTC
- Message-ID
- <1d866847-7535-8905-a8ad-a1feb158fa36@gmail.com>
- In-Reply-To
- <34a58449-4f2e-66ef-ea01-119186aebd23@gmail.com>
In bcfc82bd48 (branch: description for non-existent branch errors, 2022-10-08) we check the current HEAD to detect if the branch to operate with is an orphan branch, to avoid the confusing error: "No branch named...".
If we are asked to operate with an orphan branch in a different working tree than the current one, we need to check the HEAD in that different working tree.
Let's extend the check we did in bcfc82db48, to all HEADs in the repository, using the helper introduced in 31ad6b61bd (branch: add branch_checked_out() helper, 2022-06-15)
"ishead_reject_rebase_or_bised_branch()" already returns whether the branch to operate with is HEAD in any working tree in the repository. Let's use this information in "copy_or_rename_branch()", instead of the helper.
Note that we now call reject_rebase_or_bisect_branch() earlier, which introduces a change in the error displayed when a combination of unsupported conditions occur simultaneously: the desired destination name is invalid, and the branch to operate on is being overrun or bisected. With "foo" being rebased or bisected, this:
$ git branch -m foo HEAD fatal: 'HEAD' is not a valid branch name.
... becomes:
$ git branch -m foo HEAD fatal: Branch refs/heads/foo is being ...
Signed-off-by: Rubén Justo <rjusto@gmail.com> --- builtin/branch.c | 25 +++++++++++-------------- t/t3202-show-branch.sh | 18 ++++++++++++++++++ 2 files changed, 29 insertions(+), 14 deletions(-)
diff --git a/builtin/branch.c b/builtin/branch.c index a1ee728ca3..6bb5f50950 100644 --- a/builtin/branch.c +++ b/builtin/branch.c @@ -532,12 +532,12 @@ static void copy_or_rename_branch(const char *oldname, const char *newname, int die(_("Invalid branch name: '%s'"), oldname); } - if ((copy || strcmp(head, oldname)) && !ref_exists(oldref.buf)) { - if (copy && !strcmp(head, oldname)) - die(_("No commit on branch '%s' yet."), oldname); - else - die(_("No branch named '%s'."), oldname); - } + ishead = ishead_and_reject_rebase_or_bisect_branch(oldref.buf); + + if ((copy || !ishead) && !ref_exists(oldref.buf)) + die(ishead + ? _("No commit on branch '%s' yet.") + : _("No branch named '%s'."), oldname); /* * A command like "git branch -M currentbranch currentbranch" cannot @@ -548,8 +548,6 @@ static void copy_or_rename_branch(const char *oldname, const char *newname, int else validate_new_branchname(newname, &newref, force); - ishead = ishead_and_reject_rebase_or_bisect_branch(oldref.buf); - if (!skip_prefix(oldref.buf, "refs/heads/", &interpreted_oldname) || !skip_prefix(newref.buf, "refs/heads/", &interpreted_newname)) { BUG("expected prefix missing for refs"); @@ -810,7 +808,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix) strbuf_addf(&branch_ref, "refs/heads/%s", branch_name); if (!ref_exists(branch_ref.buf)) - error((!argc || !strcmp(head, branch_name)) + error((!argc || branch_checked_out(branch_ref.buf)) ? _("No commit on branch '%s' yet.") : _("No branch named '%s'."), branch_name); @@ -854,11 +852,10 @@ int cmd_branch(int argc, const char **argv, const char *prefix) die(_("no such branch '%s'"), argv[0]); } - if (!ref_exists(branch->refname)) { - if (!argc || !strcmp(head, branch->name)) - die(_("No commit on branch '%s' yet."), branch->name); - die(_("branch '%s' does not exist"), branch->name); - } + if (!ref_exists(branch->refname)) + die((!argc || branch_checked_out(branch->refname)) + ? _("No commit on branch '%s' yet.") + : _("branch '%s' does not exist"), branch->name); dwim_and_setup_tracking(the_repository, branch->name, new_upstream, BRANCH_TRACK_OVERRIDE, diff --git a/t/t3202-show-branch.sh b/t/t3202-show-branch.sh index ea7cfd1951..be20ebe1d5 100755 --- a/t/t3202-show-branch.sh +++ b/t/t3202-show-branch.sh @@ -221,4 +221,22 @@ test_expect_success 'fatal descriptions on non-existent branch' ' test_cmp expect actual ' +test_expect_success 'error descriptions on orphan branch' ' + test_when_finished git worktree remove -f wt && + git worktree add wt --detach && + git -C wt checkout --orphan orphan-branch && + test_branch_op_in_wt() { + test_orphan_error() { + test_must_fail git $* 2>actual && + test_i18ngrep "No commit on branch .orphan-branch. yet.$" actual + } && + test_orphan_error -C wt branch $1 $2 && # implicit branch + test_orphan_error -C wt branch $1 orphan-branch $2 && # explicit branch + test_orphan_error branch $1 orphan-branch $2 # different worktree + } && + test_branch_op_in_wt --edit-description && + test_branch_op_in_wt --set-upstream-to=ne && + test_branch_op_in_wt -c new-branch +' + test_done
-- 2.39.0