git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman

From
Ben Peart <peartben@gmail.com>
Date
Oct 20, 2017, 13:17 UTC
Message-ID
<c43315f3-4155-6b07-bde2-5855dceacf80@gmail.com>
In-Reply-To
<alpine.DEB.2.21.1.1710201459020.40514@virtualbox>
On 10/20/2017 9:00 AM, Johannes Schindelin wrote:
Show 25 quoted lines
> Hi Alex,
> 
> On Thu, 19 Oct 2017, Alex Vandiver wrote:
> 
>> This provides small performance savings.
>>
>> diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman
>> index 377edc7be..eba46c78b 100755
>> --- a/t/t7519/fsmonitor-watchman
>> +++ b/t/t7519/fsmonitor-watchman
>> @@ -51,7 +51,7 @@ launch_watchman();
>>   
>>   sub launch_watchman {
>>   
>> -	my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j')
>> +	my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j --no-pretty')
> 
> While I am very much infavor of this change (I was not aware of the
> --no-pretty option), I would like to see some statistics on that. Could
> you measure the impact, please, and include the results in the commit
> message?
> 
> Ciao,
> Johannes
>

I was also unaware of the --no-pretty option. I've tested this on Windows running version 4.9.0 of Watchman and verified that it does work correctly. I'm also curious if it produces any measurable difference in performance.

Previous: Johannes SchindelinNext: Alex Vandiver
Message 4 of 21 in “fsmonitor fixes”
  1. 0/4 fsmonitor fixesAlex Vandiver, Oct 20, 2017
  2. 2/4 fsmonitor: Don't bother pretty-printing JSON from watchmanAlex Vandiver, Oct 20, 2017
  3. Johannes SchindelinOct 20, 2017
  4. Ben PeartOct 20, 2017
  5. Alex VandiverOct 26, 2017
  6. Johannes SchindelinOct 27, 2017
  7. 3/4 fsmonitor: Document GIT_TRACE_FSMONITORAlex Vandiver, Oct 20, 2017
  8. Ben PeartOct 20, 2017
  9. 4/4 fsmonitor: Delay updating state until after split index is mergedAlex Vandiver, Oct 20, 2017
  10. Johannes SchindelinOct 20, 2017
  11. Ben PeartOct 20, 2017
  12. Junio C HamanoOct 21, 2017
  13. Jeff KingOct 21, 2017
  14. Johannes SchindelinOct 23, 2017
  15. Ben PeartOct 23, 2017
  16. Alex VandiverOct 26, 2017
  17. 1/4 fsmonitor: Watch, and ask about, the top of the repo, not the CWDAlex Vandiver, Oct 20, 2017
  18. Johannes SchindelinOct 20, 2017
  19. Alex VandiverOct 26, 2017
  20. Johannes SchindelinOct 27, 2017
  21. Johannes SchindelinOct 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.