Re: [PATCH 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 20, 2017, 13:00 UTC
- Message-ID
- <alpine.DEB.2.21.1.1710201459020.40514@virtualbox>
- In-Reply-To
- <6887851348e177728849964cc95ae783b0feb971.1508461850.git.alexmv@dropbox.com>
Hi Alex,
On Thu, 19 Oct 2017, Alex Vandiver wrote:
Show 12 quoted lines
> This provides small performance savings.
>
> diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman
> index 377edc7be..eba46c78b 100755
> --- a/t/t7519/fsmonitor-watchman
> +++ b/t/t7519/fsmonitor-watchman
> @@ -51,7 +51,7 @@ launch_watchman();
>
> sub launch_watchman {
>
> - my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j')
> + my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j --no-pretty')While I am very much infavor of this change (I was not aware of the --no-pretty option), I would like to see some statistics on that. Could you measure the impact, please, and include the results in the commit message?
Ciao, Johannes