From: Ben Peart <peartben@gmail.com>
Date: Fri, 20 Oct 2017 13:17:14 GMT
Subject: Re: [PATCH 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman
Message-ID: <c43315f3-4155-6b07-bde2-5855dceacf80@gmail.com>
In-Reply-To: <alpine.DEB.2.21.1.1710201459020.40514@virtualbox>



On 10/20/2017 9:00 AM, Johannes Schindelin wrote:
> Hi Alex,
> 
> On Thu, 19 Oct 2017, Alex Vandiver wrote:
> 
>> This provides small performance savings.
>>
>> diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman
>> index 377edc7be..eba46c78b 100755
>> --- a/t/t7519/fsmonitor-watchman
>> +++ b/t/t7519/fsmonitor-watchman
>> @@ -51,7 +51,7 @@ launch_watchman();
>>   
>>   sub launch_watchman {
>>   
>> -	my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j')
>> +	my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j --no-pretty')
> 
> While I am very much infavor of this change (I was not aware of the
> --no-pretty option), I would like to see some statistics on that. Could
> you measure the impact, please, and include the results in the commit
> message?
> 
> Ciao,
> Johannes
> 

I was also unaware of the --no-pretty option. I've tested this on 
Windows running version 4.9.0 of Watchman and verified that it does work 
correctly.  I'm also curious if it produces any measurable difference in 
performance.