git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/6] fixup! Add reftable library

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
May 4, 2020, 13:31 UTC
Message-ID
<c41b25e963973dac1eb50cd3ae1f79741bc89ed1.1588599086.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.623.git.1588599086.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
`usleep()` is unportable. We need to find a way _not_ to use it.

For Visual C, we can use `sleep_millisec()`, but the current design of libreftable seems to be _really_ keen _not_ to depend on anything in libgit.a.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 reftable/stack.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/reftable/stack.c b/reftable/stack.c
index 3c5f4a43130..2d0b831dda1 100644
--- a/reftable/stack.c
+++ b/reftable/stack.c
@@ -289,7 +289,12 @@ static int reftable_stack_reload_maybe_reuse(struct reftable_stack *st,
 		free_names(names_after);
 
 		delay = delay + (delay * rand()) / RAND_MAX + 100;
+#ifdef _MSC_VER
+		sleep_millisec(delay/1000);
+#else
+		/* TODO! fix this, `usleep()` is not portable enough for us to use */
 		usleep(delay);
+#endif
 	}
 
 	return 0;
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 4 of 12 in “Minimal patch series to fix the CI runs of hn/reftable”
  1. 0/6 Minimal patch series to fix the CI runs of hn/reftableJohannes Schindelin via GitGitGadget, May 4, 2020
  2. 1/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  3. 2/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  4. 4/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  5. 3/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  6. 6/6 vcxproj: adjust for the reftable changesJohannes Schindelin via GitGitGadget, May 4, 2020
  7. Junio C HamanoMay 4, 2020
  8. 5/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  9. Junio C HamanoMay 4, 2020
  10. Johannes SchindelinMay 5, 2020
  11. Han-Wen NienhuysMay 4, 2020
  12. Johannes SchindelinMay 5, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.