git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/6] fixup! Add reftable library

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
May 4, 2020, 13:31 UTC
Message-ID
<6f1868a2fe21e59d80a81b837810b09aa86a6838.1588599086.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.623.git.1588599086.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
A `void` function cannot return a value.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 reftable/record.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/reftable/record.c b/reftable/record.c
index b0f18f26c55..5f48be1639e 100644
--- a/reftable/record.c
+++ b/reftable/record.c
@@ -1005,7 +1005,7 @@ int record_decode(struct record rec, struct slice key, byte extra,
 
 void record_clear(struct record rec)
 {
-	return rec.ops->clear(rec.data);
+	rec.ops->clear(rec.data);
 }
 
 bool record_is_deletion(struct record rec)
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 5 of 12 in “Minimal patch series to fix the CI runs of hn/reftable”
  1. 0/6 Minimal patch series to fix the CI runs of hn/reftableJohannes Schindelin via GitGitGadget, May 4, 2020
  2. 1/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  3. 2/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  4. 4/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  5. 3/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  6. 6/6 vcxproj: adjust for the reftable changesJohannes Schindelin via GitGitGadget, May 4, 2020
  7. Junio C HamanoMay 4, 2020
  8. 5/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  9. Junio C HamanoMay 4, 2020
  10. Johannes SchindelinMay 5, 2020
  11. Han-Wen NienhuysMay 4, 2020
  12. Johannes SchindelinMay 5, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.