git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/6] fixup! Add reftable library

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
May 4, 2020, 13:31 UTC
Message-ID
<a11d1cd304153718363f18c33d1ae87f38b3fb21.1588599086.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.623.git.1588599086.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

Close files before trying to unlink them. This is actually required on Windows.

Note: this is probably not the only part of the code that requires this
type of fix, but it seems to be enough to let the _current_ version of
t0031 pass.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 reftable/stack.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/reftable/stack.c b/reftable/stack.c
index e7b625d924a..2e32f7671c2 100644
--- a/reftable/stack.c
+++ b/reftable/stack.c
@@ -852,6 +852,10 @@ static int stack_compact_range(struct reftable_stack *st, int first, int last,
 		}
 	}
 
+	if (lock_file_fd > 0) {
+		close(lock_file_fd);
+		lock_file_fd = 0;
+	}
 	err = unlink(slice_as_string(&lock_file_name));
 	if (err < 0) {
 		goto exit;
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 2 of 12 in “Minimal patch series to fix the CI runs of hn/reftable”
  1. 0/6 Minimal patch series to fix the CI runs of hn/reftableJohannes Schindelin via GitGitGadget, May 4, 2020
  2. 1/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  3. 2/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  4. 4/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  5. 3/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  6. 6/6 vcxproj: adjust for the reftable changesJohannes Schindelin via GitGitGadget, May 4, 2020
  7. Junio C HamanoMay 4, 2020
  8. 5/6 fixup! Add reftable libraryJohannes Schindelin via GitGitGadget, May 4, 2020
  9. Junio C HamanoMay 4, 2020
  10. Johannes SchindelinMay 5, 2020
  11. Han-Wen NienhuysMay 4, 2020
  12. Johannes SchindelinMay 5, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.