[PATCH v2 06/25] refs_ref_iterator_begin(): don't check prefixes redundantly
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- May 22, 2017, 14:17 UTC
- Message-ID
- <c3840954c13e008ad4917a7ccf3faf5ae54b01cc.1495460199.git.mhagger@alum.mit.edu>
- In-Reply-To
- <cover.1495460199.git.mhagger@alum.mit.edu>
The backend already correctly restricts its output to references whose names start with the prefix. By passing the prefix again to `prefix_ref_iterator`, we were forcing that iterator to do redundant prefix comparisons. So set it to the empty string.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- refs.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c index 8af9641aa1..8494b1f20d 100644 --- a/refs.c +++ b/refs.c @@ -1247,7 +1247,13 @@ struct ref_iterator *refs_ref_iterator_begin( struct ref_iterator *iter; iter = refs->be->iterator_begin(refs, prefix, flags); - iter = prefix_ref_iterator_begin(iter, prefix, trim); + + /* + * `iterator_begin()` already takes care of prefix, but we + * might need to do some trimming: + */ + if (trim) + iter = prefix_ref_iterator_begin(iter, "", trim); return iter; }
-- 2.11.0