[PATCH v2 17/25] ref_update_reject_duplicates(): add a sanity check

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: May 22, 2017, 14:17 UTC
Message-ID: <8383dc8f8e30b61548374a5427da09f98a2175af.1495460199.git.mhagger@alum.mit.edu>
In-Reply-To: <cover.1495460199.git.mhagger@alum.mit.edu>

It's pretty cheap to make sure that the caller didn't pass us an unsorted list by accident, so do so.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/refs.c b/refs.c
index 143936a9c3..d1c781d94e 100644
--- a/refs.c
+++ b/refs.c
@@ -1709,13 +1709,19 @@ int ref_update_reject_duplicates(struct string_list *refnames,
 
 	assert(err);
 
-	for (i = 1; i < n; i++)
-		if (!strcmp(refnames->items[i - 1].string, refnames->items[i].string)) {
+	for (i = 1; i < n; i++) {
+		int cmp = strcmp(refnames->items[i - 1].string,
+				 refnames->items[i].string);
+
+		if (!cmp) {
 			strbuf_addf(err,
 				    "multiple updates for ref '%s' not allowed.",
 				    refnames->items[i].string);
 			return 1;
+		} else if (cmp > 0) {
+			die("BUG: ref_update_reject_duplicates() received unsorted list");
 		}
+	}
 	return 0;
 }

-- 
2.11.0