[PATCH v2 07/25] refs: use `size_t` indexes when iterating over ref transaction updates
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- May 22, 2017, 14:17 UTC
- Message-ID
- <affc4f0ef831e70009bdcecbcc1320eb78bb8cf8.1495460199.git.mhagger@alum.mit.edu>
- In-Reply-To
- <cover.1495460199.git.mhagger@alum.mit.edu>
Eliminate any chance of integer overflow on platforms where the two types have different sizes.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- refs.c | 2 +- refs/files-backend.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/refs.c b/refs.c index 8494b1f20d..71139ba74e 100644 --- a/refs.c +++ b/refs.c @@ -848,7 +848,7 @@ struct ref_transaction *ref_transaction_begin(struct strbuf *err) void ref_transaction_free(struct ref_transaction *transaction) { - int i; + size_t i; if (!transaction) return; diff --git a/refs/files-backend.c b/refs/files-backend.c index fa5d2b6f08..b2559b5585 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -2850,7 +2850,8 @@ static int files_transaction_commit(struct ref_store *ref_store, struct files_ref_store *refs = files_downcast(ref_store, REF_STORE_WRITE, "ref_transaction_commit"); - int ret = 0, i; + size_t i; + int ret = 0; struct string_list refs_to_delete = STRING_LIST_INIT_NODUP; struct string_list_item *ref_to_delete; struct string_list affected_refnames = STRING_LIST_INIT_NODUP; @@ -3057,7 +3058,8 @@ static int files_initial_transaction_commit(struct ref_store *ref_store, struct files_ref_store *refs = files_downcast(ref_store, REF_STORE_WRITE, "initial_ref_transaction_commit"); - int ret = 0, i; + size_t i; + int ret = 0; struct string_list affected_refnames = STRING_LIST_INIT_NODUP; assert(err);
-- 2.11.0