git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] bundle-uri: drop unused 'uri' parameter

From
Derrick Stolee <derrickstolee@github.com>
Date
Dec 20, 2022, 14:02 UTC
Message-ID
<be44ef00-2d80-18d5-4dab-357faca20853@github.com>
In-Reply-To
<xmqq4jtq292e.fsf@gitster.g>
On 12/19/22 7:49 PM, Junio C Hamano wrote:
Show 6 quoted lines
> I think these three patches were designed to be "oops, that was
> wrong and here is a band-aid" follow-up fixes on top of what was
> back then in 'next'.  Now the base topic has been kicked out of
> 'next' together with these, we can afford to roll them into the base
> series before merging it back to 'next', but due to things generally
> being slow toward the end of the year, that hasn't happened yet.

I wasn't expecting to re-roll the base topic, but I'll get started on that now.

However, the comments in this review are barely actionable. They provide very little value especially for how verbose they are. I'm frustrated to see such a drive-by review so late in the process.

Thanks, -Stolee

Previous: Junio C HamanoNext: Ævar Arnfjörð Bjarmason
Message 12 of 17 in “Bundle URIs 4.5: fixups from part IV”
  1. 0/3 Bundle URIs 4.5: fixups from part IVDerrick Stolee via GitGitGadget, Dec 12, 2022
  2. 2/3 bundle-uri: advertise based on repo configDerrick Stolee via GitGitGadget, Dec 12, 2022
  3. Ævar Arnfjörð BjarmasonDec 19, 2022
  4. Derrick StoleeDec 20, 2022
  5. 3/3 bundle-uri: remove GIT_TEST_BUNDLE_URI env variableDerrick Stolee via GitGitGadget, Dec 12, 2022
  6. Ævar Arnfjörð BjarmasonDec 19, 2022
  7. Derrick StoleeDec 20, 2022
  8. Ævar Arnfjörð BjarmasonDec 20, 2022
  9. 1/3 bundle-uri: drop unused 'uri' parameterDerrick Stolee via GitGitGadget, Dec 12, 2022
  10. Ævar Arnfjörð BjarmasonDec 19, 2022
  11. Junio C HamanoDec 20, 2022
  12. Derrick StoleeDec 20, 2022
  13. Ævar Arnfjörð BjarmasonDec 20, 2022
  14. Derrick StoleeDec 20, 2022
  15. Ævar Arnfjörð BjarmasonDec 20, 2022
  16. Victoria DyeDec 12, 2022
  17. Jeff KingDec 12, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.