Re: [PATCH 1/3] bundle-uri: drop unused 'uri' parameter

From: Derrick Stolee <derrickstolee@github.com>
Date: Dec 20, 2022, 13:57 UTC
Message-ID: <75107325-bd28-1adf-b260-ba8846c63229@github.com>
In-Reply-To: <221219.86tu1rzmbs.gmgdl@evledraar.gmail.com>

On 12/19/22 5:57 AM, Ævar Arnfjörð Bjarmason wrote:

> On Mon, Dec 12 2022, Derrick Stolee via GitGitGadget wrote:

Show 7 quoted lines

>> @@ -112,10 +112,10 @@ int fetch_bundle_uri(struct repository *r, const char *uri);
>>   * bundle-uri protocol v2 verb) at the given uri, fetch and unbundle the
>>   * bundles according to the bundle strategy of that list.
>>   *
>> - * Returns non-zero if no bundle information is found at the given 'uri'.
>> + * It is expected that the given 'list' is initialized, including its
>> + * 'baseURI' value

> The same goes for the added docs, that we "expect [that] 'list' is
> initialized" may be true, but that would have been true before we
> removed this unused parameter, so let's not stick that in this unrelated
> "UNUSED" change.

It is _not_ unrelated. The 'uri' parameter looks like it should be used to determine relative URLs for the included list. However, this reasoning around the 'baseURI' value points out that we are using that value _instead_ of the 'uri' value, which is why it is safe to remove the parameter.

Thanks, -Stolee