git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Avoid warning when From: is encoded

From
SRSverre Rabbelier <alturin@gmail.com>
Date
Jul 25, 2008, 16:01 UTC
Message-ID
<bd6139dc0807250901n7408a8e6w5dead238e897fc03@mail.gmail.com>
In-Reply-To
<20080725131625.GA11221@toroid.org>
On Fri, Jul 25, 2008 at 15:16, Abhijit Menon-Sen <ams@toroid.org> wrote:
> At 2008-07-25 15:06:48 +0200, 4ux6as402@sneakemail.com wrote:
>> Are there any form problems with this patch?

Usually the "comment" part is indented by at least one level, but afaik that's just etiquette and is not mandatory.

> The patch itself also looks good to me (but I'm not sure if that means I
> should add an Acked-by: line to this message).

Acked-by is reserved for people who are "owners" of the area the patch touches. So for example, a patch to git-gui could be Acked-by Shawn O. Pierce, or one related to pack format by Nico (I think?). So you should Ack it if you have done (a lot of) work in the same area as the patch before and if the patch looks good.

-- 
Cheers,

Sverre Rabbelier
Previous: Abhijit Menon-SenNext: Jon Loeliger
Message 3 of 7 in “Avoid warning when From: is encoded”
  1. Avoid warning when From: is encodedPeter Valdemar Mørch, Jul 25, 2008
  2. Abhijit Menon-SenJul 25, 2008
  3. Sverre RabbelierJul 25, 2008
  4. Jon LoeligerJul 25, 2008
  5. Johannes SchindelinJul 26, 2008
  6. Junio C HamanoJul 25, 2008
  7. Jeff KingJul 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.