git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Avoid warning when From: is encoded

From
Jeff King <peff@peff.net>
Date
Jul 25, 2008, 18:38 UTC
Message-ID
<20080725183857.GE4375@sigill.intra.peff.net>
In-Reply-To
<7vhcadudmz.fsf@gitster.siamese.dyndns.org>
On Fri, Jul 25, 2008 at 09:33:56AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> > In commit 0706bd19ef9b41e7519df2c73796ef93484272fd $1 is used from a regexp
> > without using () to set up $1. Later, when that value was used, it caused a
> > warning about a variable being undefined.
> >
> > Signed-off-by: Peter Valdemar Mørch <peter@morch.com>
> 
> Thanks.  The patch is obviously correct; I think you are fixing 8291db6
> (git-send-email: add charset header if we add encoded 'From', 2007-11-16),
> not 0706bd1 (send-email: specify content-type of --compose body,
> 2008-03-28).
> 
> Will apply to maint and merge upwards.

Discussions about who can ACK this code aside, the original bogosity was totally mine, so

  Acked-by: Jeff King <peff@peff.net>
-Peff
Previous: Junio C Hamano
Message 7 of 7 in “Avoid warning when From: is encoded”
  1. Avoid warning when From: is encodedPeter Valdemar Mørch, Jul 25, 2008
  2. Abhijit Menon-SenJul 25, 2008
  3. Sverre RabbelierJul 25, 2008
  4. Jon LoeligerJul 25, 2008
  5. Johannes SchindelinJul 26, 2008
  6. Junio C HamanoJul 25, 2008
  7. Jeff KingJul 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.