From: Sverre Rabbelier Date: Fri, 25 Jul 2008 16:01:31 GMT Subject: Re: [PATCH] Avoid warning when From: is encoded Message-ID: In-Reply-To: <20080725131625.GA11221@toroid.org> On Fri, Jul 25, 2008 at 15:16, Abhijit Menon-Sen wrote: > At 2008-07-25 15:06:48 +0200, 4ux6as402@sneakemail.com wrote: >> Are there any form problems with this patch? Usually the "comment" part is indented by at least one level, but afaik that's just etiquette and is not mandatory. > The patch itself also looks good to me (but I'm not sure if that means I > should add an Acked-by: line to this message). Acked-by is reserved for people who are "owners" of the area the patch touches. So for example, a patch to git-gui could be Acked-by Shawn O. Pierce, or one related to pack format by Nico (I think?). So you should Ack it if you have done (a lot of) work in the same area as the patch before and if the patch looks good. -- Cheers, Sverre Rabbelier