Re: [PATCH - stgit] Patch to allow import of compressed files

From: Sverre Rabbelier <alturin@gmail.com>
Date: Jun 10, 2008, 10:33 UTC
Message-ID: <bd6139dc0806100333s4395cca4g52b58679d7fc5c25@mail.gmail.com>
In-Reply-To: <20080610102800.GB30119@diana.vm.bytemark.co.uk>

On Tue, Jun 10, 2008 at 12:28 PM, Karl Hasselström <kha@treskal.com> wrote:

> If there's just one patch in the tar file, why did you use a tar file
> in the first place instead of just gzipping?

I guess mostly habbit :P. Whenever I zip something I create a gzipped tarball because that's how I usually do it.

> I'm pretty sure that anyone who really has use for the tar-file
> capability would be using tar files with multiple patches in them.

Yeah, I guess that's true for most people indeed.

> I was refering to the fact that due to tar-files in the general case
> containing more than one patch, you'd have to modify the parts of
> imprt.py that deal with importing multiple patches at once, in
> addition to the parts the current patch touches.

Mhhh, yeah, but should be something like
for patch in patches
  applyPatch(patch)

> But you're probably right that the amount of additional work would not
> be much more than what went into the current patch.

To just support .tar, yeah, but let's see what the author has to say about this ;).

-- 
Cheers,

Sverre Rabbelier