Re: [PATCH - stgit] Patch to allow import of compressed files

From: Karl Hasselström <kha@treskal.com>
Date: Jun 10, 2008, 06:33 UTC
Message-ID: <20080610063328.GB26965@diana.vm.bytemark.co.uk>
In-Reply-To: <484D78BF.6030504@gmail.com>

On 2008-06-09 13:38:55 -0500, Clark Williams wrote:

Show 10 quoted lines

> This patch allows StGit to directly import compressed (.gz and .bz2)
> files with reasonable patch names.
>
> I do a lot of work on modified kernel trees and usually the first
> two things imported are a stable update patch followed immediately
> by an -rt patch, both of which are compressed. With this patch I can
> just copy the files down directly from kernel.org and import them,
> rather than having to keep uncompressed copies around.
>
> Hey, I'm lazy... :)

Lazy is good. Thanks for the patch!

Show 8 quoted lines

> +        if filename.endswith(".gz"):
> +            import gzip
> +            f = gzip.open(filename)
> +            pname = filename.replace(".gz", "")
> +        elif filename.endswith(".bz2"):
> +            import bz2
> +            f = bz2.BZ2File(filename, 'r')
> +            pname = filename.replace(".bz2", "")

Some comments here:

  * By my reading of the docs, the second argument to BZ2File defaults
    to 'r' anyway, so you could omit it.

  * We try to use single quotes wherever possible (except when triple
    quoting). You're using a mix ...

  * .replace() will happily replace anywhere in the string. Please
    consider using stgit.util.strip_suffix() instead.

And last but not least, it'd be terrific if you'd let me bully you into adding .gz and .bz2 test cases for t1800-import. :-)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle