Re: [PATCH - stgit] Patch to allow import of compressed files

From: Karl Hasselström <kha@treskal.com>
Date: Jun 10, 2008, 10:28 UTC
Message-ID: <20080610102800.GB30119@diana.vm.bytemark.co.uk>
In-Reply-To: <bd6139dc0806100257k4700d364occ08457279e8a735@mail.gmail.com>

On 2008-06-10 11:57:05 +0200, Sverre Rabbelier wrote:

Show 7 quoted lines

> On Tue, Jun 10, 2008 at 11:53 AM, Karl Hasselström <kha@treskal.com> wrote:
>
> > A tar file would presumably contain more than one patch -- it'd be
> > more like a directory of patches than a single patch file.
>
> Why?
> $ tar czvf mypatch.patch.tar.gz mypatch.patch

If there's just one patch in the tar file, why did you use a tar file in the first place instead of just gzipping?

I'm pretty sure that anyone who really has use for the tar-file capability would be using tar files with multiple patches in them.

Show 7 quoted lines

> > I'm not saying it wouldn't be nice to support it, but it's not
> > what the original poster needed, and building it would be a bunch
> > of extra work.
>
> A bunch of extra work?
> http://docs.python.org/lib/module-tarfile.html I say it'd be about
> as much work as the original patch ;).

I was refering to the fact that due to tar-files in the general case containing more than one patch, you'd have to modify the parts of imprt.py that deal with importing multiple patches at once, in addition to the parts the current patch touches.

But you're probably right that the amount of additional work would not be much more than what went into the current patch.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle