git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 11/20] t4003-diff-rename-1: modernize test format

From
John Cai via GitGitGadget <gitgitgadget@gmail.com>
Date
May 18, 2023, 20:03 UTC
Message-ID
<bb9abb10c6ed11a6ab528e09fca67cf1b0e29a18.1684440206.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1513.git.git.1684440205.gitgitgadget@gmail.com>
From: John Cai <johncai86@gmail.com>

Some tests still use the old format with four spaces indentation. Standardize the tests to the new format with tab indentation.

Signed-off-by: John Cai <johncai86@gmail.com>
---
 t/t4003-diff-rename-1.sh | 62 ++++++++++++++++++++--------------------
 1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/t/t4003-diff-rename-1.sh b/t/t4003-diff-rename-1.sh
index 181e9683a79..ebe091828c8 100755
--- a/t/t4003-diff-rename-1.sh
+++ b/t/t4003-diff-rename-1.sh
@@ -11,20 +11,20 @@ TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-diff.sh ;# test-lib chdir's into trash
 
-test_expect_success \
-    'prepare reference tree' \
-    'COPYING_test_data >COPYING &&
-     echo frotz >rezrov &&
-    git update-index --add COPYING rezrov &&
-    tree=$(git write-tree) &&
-    echo $tree'
-
-test_expect_success \
-    'prepare work tree' \
-    'sed -e 's/HOWEVER/However/' <COPYING >COPYING.1 &&
-    sed -e 's/GPL/G.P.L/g' <COPYING >COPYING.2 &&
-    rm -f COPYING &&
-    git update-index --add --remove COPYING COPYING.?'
+test_expect_success 'prepare reference tree' '
+	COPYING_test_data >COPYING &&
+	echo frotz >rezrov &&
+	git update-index --add COPYING rezrov &&
+	tree=$(git write-tree) &&
+	echo $tree
+'
+
+test_expect_success 'prepare work tree' '
+	sed -e 's/HOWEVER/However/' <COPYING >COPYING.1 &&
+	sed -e 's/GPL/G.P.L/g' <COPYING >COPYING.2 &&
+	rm -f COPYING &&
+	git update-index --add --remove COPYING COPYING.?
+'
 
 # tree has COPYING and rezrov.  work tree has COPYING.1 and COPYING.2,
 # both are slightly edited, and unchanged rezrov.  So we say you
@@ -57,14 +57,14 @@ rename to COPYING.2
 +	This file is licensed under the G.P.L v2, or a later version
 EOF
 
-test_expect_success \
-    'validate output from rename/copy detection (#1)' \
-    'compare_diff_patch current expected'
+test_expect_success 'validate output from rename/copy detection (#1)' '
+	compare_diff_patch current expected
+'
 
-test_expect_success \
-    'prepare work tree again' \
-    'mv COPYING.2 COPYING &&
-     git update-index --add --remove COPYING COPYING.1 COPYING.2'
+test_expect_success 'prepare work tree again' '
+	mv COPYING.2 COPYING &&
+	git update-index --add --remove COPYING COPYING.1 COPYING.2
+'
 
 # tree has COPYING and rezrov.  work tree has COPYING and COPYING.1,
 # both are slightly edited, and unchanged rezrov.  So we say you
@@ -95,14 +95,14 @@ copy to COPYING.1
 + However, in order to allow a migration to GPLv3 if that seems like
 EOF
 
-test_expect_success \
-    'validate output from rename/copy detection (#2)' \
-    'compare_diff_patch current expected'
+test_expect_success 'validate output from rename/copy detection (#2)' '
+	compare_diff_patch current expected
+'
 
-test_expect_success \
-    'prepare work tree once again' \
-    'COPYING_test_data >COPYING &&
-     git update-index --add --remove COPYING COPYING.1'
+test_expect_success 'prepare work tree once again' '
+	COPYING_test_data >COPYING &&
+	git update-index --add --remove COPYING COPYING.1
+'
 
 # tree has COPYING and rezrov.  work tree has COPYING and COPYING.1,
 # but COPYING is not edited.  We say you copy-and-edit COPYING.1; this
@@ -123,8 +123,8 @@ copy to COPYING.1
 + However, in order to allow a migration to GPLv3 if that seems like
 EOF
 
-test_expect_success \
-    'validate output from rename/copy detection (#3)' \
-    'compare_diff_patch current expected'
+test_expect_success 'validate output from rename/copy detection (#3)' '
+	compare_diff_patch current expected
+'
 
 test_done
-- 
gitgitgadget
Previous: John Cai via GitGitGadgetNext: John Cai via GitGitGadget
Message 16 of 25 in “tests: modernize test format”
  1. 00/20 tests: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  2. 01/20 t1000-basic: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  3. Eric SunshineMay 18, 2023
  4. 02/20 t0030-stripspace: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  5. 04/20 t1001-read-tree-m-2way: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  6. 03/20 t3210-pack-refs: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  7. Junio C HamanoMay 19, 2023
  8. John CaiMay 19, 2023
  9. Junio C HamanoMay 19, 2023
  10. 06/20 t1006-cat-file: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  11. 07/20 t3500-cherry: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  12. 08/20 t3700-add: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  13. 05/20 t1002-read-tree-m-u-2way: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  14. 09/20 t3903-stash: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  15. 10/20 t4002-diff-basic: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  16. 11/20 t4003-diff-rename-1: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  17. 12/20 t4004-diff-rename-symlink: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  18. 13/20 t4202-log: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  19. 14/20 t4206-log-follow-harder-copies: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  20. 15/20 t5300-pack-object: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  21. 16/20 t5301-sliding-window: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  22. 18/20 t5306-pack-nobase: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  23. 17/20 t5303-pack-corruption-resilience: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  24. 19/20 t6050-replace: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  25. 20/20 t7101-reset-empty-subdirs: modernize test formatJohn Cai via GitGitGadget, May 18, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.