git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/20] t4004-diff-rename-symlink: modernize test format

From
John Cai via GitGitGadget <gitgitgadget@gmail.com>
Date
May 18, 2023, 20:03 UTC
Message-ID
<5ed43aca06f9617c0dd7425b14d0e8c470c2c72d.1684440206.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1513.git.git.1684440205.gitgitgadget@gmail.com>
From: John Cai <johncai86@gmail.com>

Some tests still use the old format with four spaces indentation. Standardize the tests to the new format with tab indentation.

Signed-off-by: John Cai <johncai86@gmail.com>
---
 t/t4004-diff-rename-symlink.sh | 42 +++++++++++++++++-----------------
 1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/t/t4004-diff-rename-symlink.sh b/t/t4004-diff-rename-symlink.sh
index 8def4d4aee9..1d70d4d221b 100755
--- a/t/t4004-diff-rename-symlink.sh
+++ b/t/t4004-diff-rename-symlink.sh
@@ -14,21 +14,21 @@ TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-diff.sh
 
-test_expect_success SYMLINKS \
-    'prepare reference tree' \
-    'echo xyzzy | tr -d '\\\\'012 >yomin &&
-     ln -s xyzzy frotz &&
-    git update-index --add frotz yomin &&
-    tree=$(git write-tree) &&
-    echo $tree'
+test_expect_success SYMLINKS 'prepare reference tree' '
+	echo xyzzy | tr -d '\\\\'012 >yomin &&
+	ln -s xyzzy frotz &&
+	git update-index --add frotz yomin &&
+	tree=$(git write-tree) &&
+	echo $tree
+'
 
-test_expect_success SYMLINKS \
-    'prepare work tree' \
-    'mv frotz rezrov &&
-     rm -f yomin &&
-     ln -s xyzzy nitfol &&
-     ln -s xzzzy bozbar &&
-    git update-index --add --remove frotz rezrov nitfol bozbar yomin'
+test_expect_success SYMLINKS 'prepare work tree' '
+	mv frotz rezrov &&
+	rm -f yomin &&
+	ln -s xyzzy nitfol &&
+	ln -s xzzzy bozbar &&
+	git update-index --add --remove frotz rezrov nitfol bozbar yomin
+'
 
 # tree has frotz pointing at xyzzy, and yomin that contains xyzzy to
 # confuse things.  work tree has rezrov (xyzzy) nitfol (xyzzy) and
@@ -36,9 +36,9 @@ test_expect_success SYMLINKS \
 # rezrov and nitfol are rename/copy of frotz and bozbar should be
 # a new creation.
 
-test_expect_success SYMLINKS 'setup diff output' "
-    GIT_DIFF_OPTS=--unified=0 git diff-index -C -p $tree >current &&
-    cat >expected <<\EOF
+test_expect_success SYMLINKS 'setup diff output' '
+	GIT_DIFF_OPTS=--unified=0 git diff-index -C -p $tree >current &&
+	cat >expected <<\EOF
 diff --git a/bozbar b/bozbar
 new file mode 120000
 --- /dev/null
@@ -62,10 +62,10 @@ deleted file mode 100644
 -xyzzy
 \ No newline at end of file
 EOF
-"
+'
 
-test_expect_success SYMLINKS \
-    'validate diff output' \
-    'compare_diff_patch current expected'
+test_expect_success SYMLINKS 'validate diff output' '
+	compare_diff_patch current expected
+'
 
 test_done
-- 
gitgitgadget
Previous: John Cai via GitGitGadgetNext: John Cai via GitGitGadget
Message 17 of 25 in “tests: modernize test format”
  1. 00/20 tests: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  2. 01/20 t1000-basic: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  3. Eric SunshineMay 18, 2023
  4. 02/20 t0030-stripspace: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  5. 04/20 t1001-read-tree-m-2way: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  6. 03/20 t3210-pack-refs: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  7. Junio C HamanoMay 19, 2023
  8. John CaiMay 19, 2023
  9. Junio C HamanoMay 19, 2023
  10. 06/20 t1006-cat-file: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  11. 07/20 t3500-cherry: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  12. 08/20 t3700-add: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  13. 05/20 t1002-read-tree-m-u-2way: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  14. 09/20 t3903-stash: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  15. 10/20 t4002-diff-basic: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  16. 11/20 t4003-diff-rename-1: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  17. 12/20 t4004-diff-rename-symlink: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  18. 13/20 t4202-log: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  19. 14/20 t4206-log-follow-harder-copies: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  20. 15/20 t5300-pack-object: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  21. 16/20 t5301-sliding-window: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  22. 18/20 t5306-pack-nobase: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  23. 17/20 t5303-pack-corruption-resilience: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  24. 19/20 t6050-replace: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  25. 20/20 t7101-reset-empty-subdirs: modernize test formatJohn Cai via GitGitGadget, May 18, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.