git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 16/20] t5301-sliding-window: modernize test format

From
John Cai via GitGitGadget <gitgitgadget@gmail.com>
Date
May 18, 2023, 20:03 UTC
Message-ID
<6325c8f48c4fd36cc509d4a20e5eb4d6377547b0.1684440206.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1513.git.git.1684440205.gitgitgadget@gmail.com>
From: John Cai <johncai86@gmail.com>

Some tests still use the old format with four spaces indentation. Standardize the tests to the new format with tab indentation.

Signed-off-by: John Cai <johncai86@gmail.com>
---
 t/t5301-sliding-window.sh | 100 +++++++++++++++++++-------------------
 1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/t/t5301-sliding-window.sh b/t/t5301-sliding-window.sh
index 3ccaaeb3977..226490d60df 100755
--- a/t/t5301-sliding-window.sh
+++ b/t/t5301-sliding-window.sh
@@ -8,55 +8,55 @@ test_description='mmap sliding window tests'
 TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
-test_expect_success \
-    'setup' \
-    'rm -f .git/index* &&
-     for i in a b c
-     do
-         echo $i >$i &&
-	 test-tool genrandom "$i" 32768 >>$i &&
-         git update-index --add $i || return 1
-     done &&
-     echo d >d && cat c >>d && git update-index --add d &&
-     tree=$(git write-tree) &&
-     commit1=$(git commit-tree $tree </dev/null) &&
-     git update-ref HEAD $commit1 &&
-     git repack -a -d &&
-     test "$(git count-objects)" = "0 objects, 0 kilobytes" &&
-     pack1=$(ls .git/objects/pack/*.pack) &&
-     test -f "$pack1"'
-
-test_expect_success \
-    'verify-pack -v, defaults' \
-    'git verify-pack -v "$pack1"'
-
-test_expect_success \
-    'verify-pack -v, packedGitWindowSize == 1 page' \
-    'git config core.packedGitWindowSize 512 &&
-     git verify-pack -v "$pack1"'
-
-test_expect_success \
-    'verify-pack -v, packedGit{WindowSize,Limit} == 1 page' \
-    'git config core.packedGitWindowSize 512 &&
-     git config core.packedGitLimit 512 &&
-     git verify-pack -v "$pack1"'
-
-test_expect_success \
-    'repack -a -d, packedGit{WindowSize,Limit} == 1 page' \
-    'git config core.packedGitWindowSize 512 &&
-     git config core.packedGitLimit 512 &&
-     commit2=$(git commit-tree $tree -p $commit1 </dev/null) &&
-     git update-ref HEAD $commit2 &&
-     git repack -a -d &&
-     test "$(git count-objects)" = "0 objects, 0 kilobytes" &&
-     pack2=$(ls .git/objects/pack/*.pack) &&
-     test -f "$pack2" &&
-     test "$pack1" \!= "$pack2"'
-
-test_expect_success \
-    'verify-pack -v, defaults' \
-    'git config --unset core.packedGitWindowSize &&
-     git config --unset core.packedGitLimit &&
-     git verify-pack -v "$pack2"'
+test_expect_success 'setup' '
+	rm -f .git/index* &&
+	for i in a b c
+	do
+	echo $i >$i &&
+	test-tool genrandom "$i" 32768 >>$i &&
+	git update-index --add $i || return 1
+	done &&
+	echo d >d && cat c >>d && git update-index --add d &&
+	tree=$(git write-tree) &&
+	commit1=$(git commit-tree $tree </dev/null) &&
+	git update-ref HEAD $commit1 &&
+	git repack -a -d &&
+	test "$(git count-objects)" = "0 objects, 0 kilobytes" &&
+	pack1=$(ls .git/objects/pack/*.pack) &&
+	test -f "$pack1"
+'
+
+test_expect_success 'verify-pack -v, defaults' '
+	git verify-pack -v "$pack1"
+'
+
+test_expect_success 'verify-pack -v, packedGitWindowSize == 1 page' '
+	git config core.packedGitWindowSize 512 &&
+	git verify-pack -v "$pack1"
+'
+
+test_expect_success 'verify-pack -v, packedGit{WindowSize,Limit} == 1 page' '
+	git config core.packedGitWindowSize 512 &&
+	git config core.packedGitLimit 512 &&
+	git verify-pack -v "$pack1"
+'
+
+test_expect_success 'repack -a -d, packedGit{WindowSize,Limit} == 1 page' '
+	git config core.packedGitWindowSize 512 &&
+	git config core.packedGitLimit 512 &&
+	commit2=$(git commit-tree $tree -p $commit1 </dev/null) &&
+	git update-ref HEAD $commit2 &&
+	git repack -a -d &&
+	test "$(git count-objects)" = "0 objects, 0 kilobytes" &&
+	pack2=$(ls .git/objects/pack/*.pack) &&
+	test -f "$pack2" &&
+	test "$pack1" \!= "$pack2"
+'
+
+test_expect_success 'verify-pack -v, defaults' '
+	git config --unset core.packedGitWindowSize &&
+	git config --unset core.packedGitLimit &&
+	git verify-pack -v "$pack2"
+'
 
 test_done
-- 
gitgitgadget
Previous: John Cai via GitGitGadgetNext: John Cai via GitGitGadget
Message 21 of 25 in “tests: modernize test format”
  1. 00/20 tests: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  2. 01/20 t1000-basic: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  3. Eric SunshineMay 18, 2023
  4. 02/20 t0030-stripspace: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  5. 04/20 t1001-read-tree-m-2way: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  6. 03/20 t3210-pack-refs: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  7. Junio C HamanoMay 19, 2023
  8. John CaiMay 19, 2023
  9. Junio C HamanoMay 19, 2023
  10. 06/20 t1006-cat-file: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  11. 07/20 t3500-cherry: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  12. 08/20 t3700-add: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  13. 05/20 t1002-read-tree-m-u-2way: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  14. 09/20 t3903-stash: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  15. 10/20 t4002-diff-basic: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  16. 11/20 t4003-diff-rename-1: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  17. 12/20 t4004-diff-rename-symlink: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  18. 13/20 t4202-log: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  19. 14/20 t4206-log-follow-harder-copies: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  20. 15/20 t5300-pack-object: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  21. 16/20 t5301-sliding-window: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  22. 18/20 t5306-pack-nobase: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  23. 17/20 t5303-pack-corruption-resilience: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  24. 19/20 t6050-replace: modernize test formatJohn Cai via GitGitGadget, May 18, 2023
  25. 20/20 t7101-reset-empty-subdirs: modernize test formatJohn Cai via GitGitGadget, May 18, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.