Re: [PATCH 05/11] branch: fix a leak in setup_tracking

From: Rubén Justo <rjusto@gmail.com>
Date: Jun 16, 2023, 22:46 UTC
Message-ID: <bb03d449-adb5-5c4d-0a2f-12a26bd48d8c@gmail.com>
In-Reply-To: <20230612032615.GE306352@coredump.intra.peff.net>

On 11-jun-2023 23:26:15, Jeff King wrote:

Show 12 quoted lines

> On Sun, Jun 11, 2023 at 08:49:51PM +0200, Rubén Justo wrote:
> 
> > The return introduced in bdaf1dfae7 was to avoid setting up the
> > tracking, but even in that case it is still necessary to do the
> > clean-up.  Let's do it.
> 
> That may be a sign that the return introduced by that commit is in the
> wrong spot (i.e., could we be checking it earlier and returning before
> doing the work that led to the allocations?).
> 
> But I didn't look too carefully, and I think for the purposes of your
> series it is OK to simply fix the leak without digging too far.

Thanks.

> 
> I'll cc the author (and quote the patch below) though, as sometimes in
> cases like these they may be interested in looking deeper themselves.

Perfect.  Thank you.