Re: [PATCH 07/11] branch: fix a leak in inherit_tracking

From: Jeff King <peff@peff.net>
Date: Jun 12, 2023, 03:48 UTC
Message-ID: <20230612034831.GG306352@coredump.intra.peff.net>
In-Reply-To: <25e68755-7073-9523-dacc-d79e4e10eb39@gmail.com>

On Sun, Jun 11, 2023 at 08:50:16PM +0200, Rubén Justo wrote:

Show 7 quoted lines

> Actually, the string we're strdup()'ing is from the struct branch
> returned by get_branch().  Which, in turn, retrieves the string from the
> global "struct repository".  This makes perfectly valid to use the
> string throughout the entire execution of create_branch().  There is no
> need to duplicate it.
> 
> Let's fix the leak, removing the strdup().

Yep, good reasoning. I agree this is a good way to fix the leak.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.