Re: [RFC PATCH 0/5] format-patch: automate cover letter range-diff
- From
Andrei Rybak <rybak.a.v@gmail.com>
- Date
- Jul 26, 2018, 12:03 UTC
- Message-ID
- <b8c65df5-d150-1bc6-1858-c2c042ae4bb2@gmail.com>
- In-Reply-To
- <20180530080325.37520-1-sunshine@sunshineco.com>
On 2018-05-30 10:03, Eric Sunshine wrote:
Show 9 quoted lines
> Dscho recently implemented a 'tbdiff' replacement as a Git builtin named > git-branch-diff[1] which computes differences between two versions of a > patch series. Such a diff can be a useful aid for reviewers when > inserted into a cover letter. However, doing so requires manual > generation (invoking git-branch-diff) and copy/pasting the result into > the cover letter. > > This series fully automates the process by adding a --range-diff option > to git-format-patch.
[...]
Show 13 quoted lines
> > Eric Sunshine (5): > format-patch: allow additional generated content in > make_cover_letter() > format-patch: add --range-diff option to embed diff in cover letter > format-patch: extend --range-diff to accept revision range > format-patch: teach --range-diff to respect -v/--reroll-count > format-patch: add --creation-weight tweak for --range-diff > > Documentation/git-format-patch.txt | 18 +++++ > builtin/log.c | 119 ++++++++++++++++++++++++----- > t/t7910-branch-diff.sh | 16 ++++ > 3 files changed, 132 insertions(+), 21 deletions(-)
Would it make sense to mention new option in the cover letter section of Documentation/SubmittingPatches?
-- Best regards, Andrei Rybak