Re: [RFC PATCH 4/5] format-patch: teach --range-diff to respect -v/--reroll-count

From: Stefan Beller <sbeller@google.com>
Date: May 30, 2018, 21:03 UTC
Message-ID: <CAGZ79ka1-emwYsEh1EQdh=pgFUV_bi2xoDu1Ajq=Z1XkkhyuDw@mail.gmail.com>
In-Reply-To: <CAPig+cRh02976beGp5c5Sw5=h86VgNZgVreCHh38QKP5udJeGg@mail.gmail.com>

On Wed, May 30, 2018 at 1:44 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

>> Unrelated to this patch: how does this series cope with range diffs
>> that are not in commit-ish but patches on the file system?
>
> I'm not following. Can you provide a concrete example to get me up to speed?

I was just wondering if things like

    git format-patch --range-diff=v3-00*.patch --reroll-count=4 -3

would be supported, but that doesn't seem to be the case, now that I read the whole series. I don't think it is crucial to support right now.

This whole series is reviewed by me and I think it is good for inclusion once we have a reroll of the range-diff series and aligned the command name to call.

Thanks, Stefan