Re: [RFC PATCH 1/5] format-patch: allow additional generated content in make_cover_letter()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 17, 2018, 10:24 UTC
Message-ID: <CAPig+cSXvo31etKLaAKjt0TSuCE+5S6gS69S3viVM2cMzy3iAw@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1807171214590.71@tvgsbejvaqbjf.bet>

On Tue, Jul 17, 2018 at 6:15 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 10 quoted lines

> On Wed, 30 May 2018, Eric Sunshine wrote:
> > make_cover_letter() returns early when it lacks sufficient state to emit
> > a diffstat, which makes it difficult to extend the function to reliably
> > emit additional generated content. Work around this shortcoming by
> > factoring diffstat-printing logic out to its own function and calling it
> > as needed without otherwise inhibiting normal control flow.
> >
> > Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
>
> Makes sense.

Thanks, but it's probably not worth spending time reviewing this RFC series. I already have a new series in the works (in fact, mostly finished) in which the implementation is drastically changed from this one. Aside from adding an --interdiff option to git-format-patch (in addition to a --range-diff option) and allowing interdiff and range-diff to be added as commentary to a single-patch, the new series also takes advantage of the newly-libified range-diff engine rather than running git-range-diff as a command. So, most or all of the code has changed.

(Though, perhaps it wouldn't hurt to review the documentation changes in this RFC series to see if I botched how I described the option.)