git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC variant 2 of 2] "needs update" considered harmful

From
ARAndré Goddard Rosa <andre.goddard@gmail.com>
Date
Jul 20, 2008, 14:03 UTC
Message-ID
<b8bf37780807200703we8f8608yb009c1039b829b23@mail.gmail.com>
In-Reply-To
<20080720112957.GE32184@machine.or.cz>
On Sun, Jul 20, 2008 at 8:29 AM, Petr Baudis <pasky@suse.cz> wrote:
Show 22 quoted lines
> On Sun, Jul 20, 2008 at 12:48:21AM -0700, Junio C Hamano wrote:
>> "git update-index --refresh", "git reset" and "git add --refresh" have
>> reported paths that have local modifications as "needs update" since the
>> beginning of git.
>>
>> Although this is logically correct in that you need to update the index at
>> that path before you can commit that change, it is now becoming more and
>> more clear, especially with the continuous push for user friendliness
>> since 1.5.0 series, that the message is suboptimal.  After all, the change
>> may be something the user might want to get rid of, and "updating" would
>> be absolutely a wrong thing to do if that is the case.
>>
>> I prepared two alternatives to solve this.  Both aim to reword the message
>> to more neutral "locally modified".
>>
>> This patch is a more straightforward variant that changes the message not
>> only for Porcelain commands ("add" and "reset") but also changes the
>> output from the plumbing command "update-index".
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> I believe this is a good thing. Scripts need to be modified for the
Thanks for doing that. I hope this goes mainline soon.
-- 
[]s,
André Goddard
Previous: Jay Soffian
Message 12 of 12 in “refresh-index: fix bitmask assignment”
  1. refresh-index: fix bitmask assignmentJunio C Hamano, Jul 20, 2008
  2. Junio C HamanoJul 20, 2008
  3. Junio C HamanoJul 20, 2008
  4. [RFC] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  5. Jay SoffianJul 21, 2008
  6. [RFC variant 1 of 2] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  7. [RFC variant 2 of 2] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  8. Petr BaudisJul 20, 2008
  9. Johannes SchindelinJul 20, 2008
  10. Junio C HamanoJul 20, 2008
  11. Jay SoffianJul 21, 2008
  12. André Goddard RosaJul 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.