git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refresh-index: fix bitmask assignment

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 20, 2008, 07:03 UTC
Message-ID
<7vk5fhf35p.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<7vtzelf4mf.fsf@gitster.siamese.dyndns.org>

This hopefully protects the previous fix (and other --refresh related options) from future breakages.

I'll squash it in to the previous one.
---
 t/t2103-update-index-ignore-missing.sh |   89 ++++++++++++++++++++++++++++++++
 1 files changed, 89 insertions(+), 0 deletions(-)
 create mode 100755 t/t2103-update-index-ignore-missing.sh
diff --git a/t/t2103-update-index-ignore-missing.sh b/t/t2103-update-index-ignore-missing.sh
new file mode 100755
index 0000000..332694e
--- /dev/null
+++ b/t/t2103-update-index-ignore-missing.sh
@@ -0,0 +1,89 @@
+#!/bin/sh
+
+test_description='update-index with options'
+
+. ./test-lib.sh
+
+test_expect_success basics '
+	>one &&
+	>two &&
+	>three &&
+
+	# need --add when adding
+	test_must_fail git update-index one &&
+	test -z "$(git ls-files)" &&
+	git update-index --add one &&
+	test zone = "z$(git ls-files)" &&
+
+	# update-index is atomic
+	echo 1 >one &&
+	test_must_fail git update-index one two &&
+	echo "M	one" >expect &&
+	git diff-files --name-status >actual &&
+	test_cmp expect actual &&
+
+	git update-index --add one two three &&
+	for i in one three two; do echo $i; done >expect &&
+	git ls-files >actual &&
+	test_cmp expect actual &&
+
+	test_tick &&
+	(
+		test_create_repo xyzzy &&
+		cd xyzzy &&
+		>file &&
+		git add file
+		git commit -m "sub initial"
+	) &&
+	git add xyzzy &&
+
+	test_tick &&
+	git commit -m initial &&
+	git tag initial
+'
+
+test_expect_success '--ignore-missing --refresh' '
+	git reset --hard initial &&
+	echo 2 >one &&
+	test_must_fail git update-index --refresh &&
+	echo 1 >one &&
+	git update-index --refresh &&
+	rm -f two &&
+	test_must_fail git update-index --refresh &&
+	git update-index --ignore-missing --refresh
+
+'
+
+test_expect_success '--unmerged --refresh' '
+	git reset --hard initial &&
+	info=$(git ls-files -s one | sed -e "s/ 0	/ 1	/") &&
+	git rm --cached one &&
+	echo "$info" | git update-index --index-info &&
+	test_must_fail git update-index --refresh &&
+	git update-index --unmerged --refresh &&
+	echo 2 >two &&
+	test_must_fail git update-index --unmerged --refresh >actual &&
+	grep two actual &&
+	! grep one actual &&
+	! grep three actual
+'
+
+test_expect_success '--ignore-submodules --refresh (1)' '
+	git reset --hard initial &&
+	rm -f two &&
+	test_must_fail git update-index --ignore-submodules --refresh
+'
+
+test_expect_success '--ignore-submodules --refresh (2)' '
+	git reset --hard initial &&
+	test_tick &&
+	(
+		cd xyzzy &&
+		git commit -m "sub second" --allow-empty
+	) &&
+	test_must_fail git update-index --refresh &&
+	test_must_fail git update-index --ignore-missing --refresh &&
+	git update-index --ignore-submodules --refresh
+'
+
+test_done
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 12 in “refresh-index: fix bitmask assignment”
  1. refresh-index: fix bitmask assignmentJunio C Hamano, Jul 20, 2008
  2. Junio C HamanoJul 20, 2008
  3. Junio C HamanoJul 20, 2008
  4. [RFC] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  5. Jay SoffianJul 21, 2008
  6. [RFC variant 1 of 2] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  7. [RFC variant 2 of 2] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  8. Petr BaudisJul 20, 2008
  9. Johannes SchindelinJul 20, 2008
  10. Junio C HamanoJul 20, 2008
  11. Jay SoffianJul 21, 2008
  12. André Goddard RosaJul 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.