git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] refresh-index: fix bitmask assignment

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 20, 2008, 06:31 UTC
Message-ID
<7vtzelf4mf.fsf@gitster.siamese.dyndns.org>

5fdeacb (Teach update-index about --ignore-submodules, 2008-05-14) added a new refresh option flag but did not assign a unique bit for it correctly, and broke "update-index --ignore-missing".

This should fix it.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * The fact that it took this long for anybody to notice the breakage
   probably means that the "--ignore-missing" option in particular but the
   ability for plumbing to allow scripting in general is not utilized by
   as many people as the design initially envisioned.
 cache.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cache.h b/cache.h
index ca382d4..9735b66 100644
--- a/cache.h
+++ b/cache.h
@@ -396,7 +396,7 @@ extern void fill_stat_cache_info(struct cache_entry *ce, struct stat *st);
 #define REFRESH_UNMERGED	0x0002	/* allow unmerged */
 #define REFRESH_QUIET		0x0004	/* be quiet about it */
 #define REFRESH_IGNORE_MISSING	0x0008	/* ignore non-existent */
-#define REFRESH_IGNORE_SUBMODULES	0x0008	/* ignore submodules */
+#define REFRESH_IGNORE_SUBMODULES	0x0010	/* ignore submodules */
 extern int refresh_index(struct index_state *, unsigned int flags, const char **pathspec, char *seen);
 
 struct lock_file {
-- 
1.5.6.4.570.g052e6
Next: Junio C Hamano
Message 1 of 12 in “refresh-index: fix bitmask assignment”
  1. refresh-index: fix bitmask assignmentJunio C Hamano, Jul 20, 2008
  2. Junio C HamanoJul 20, 2008
  3. Junio C HamanoJul 20, 2008
  4. [RFC] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  5. Jay SoffianJul 21, 2008
  6. [RFC variant 1 of 2] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  7. [RFC variant 2 of 2] "needs update" considered harmfulJunio C Hamano, Jul 20, 2008
  8. Petr BaudisJul 20, 2008
  9. Johannes SchindelinJul 20, 2008
  10. Junio C HamanoJul 20, 2008
  11. Jay SoffianJul 21, 2008
  12. André Goddard RosaJul 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.