Re: [PATCH 5/6] stg mail: add basic support for git send-email

From: Karl Wiberg <kha@treskal.com>
Date: Dec 1, 2009, 07:33 UTC
Message-ID: <b8197bcb0911302333v36d38ae3n86417911249fe9b0@mail.gmail.com>
In-Reply-To: <20091201000048.GL12733@ldl.fc.hp.com>

On Tue, Dec 1, 2009 at 1:00 AM, Alex Chiang <achiang@hp.com> wrote:

Show 16 quoted lines

> * Karl Wiberg <kha@treskal.com>:
>
> > try:
> >     try:
> >         cmd.append(path)
> >         call(cmd)
> >     except Exception, e:
> >         raise CmdException(str(e))
> > finally:
> >     os.unlink(path)
> >
> > (The combined try...except...finally statement didn't appear until
> > python 2.5, but we'd like to stay compatible with 2.4.)
>
> This statement confuses me a bit. The way I read it, I shouldn't use
> your suggestion due to compat reasons?

Oh. No, the "combined" statement would look like this:

try:
    cmd.append(path)
    call(cmd)
except Exception, e:
    raise CmdException(str(e))
finally:
    os.unlink(path)

It works exactly like the nested try...finally and try...except statement above, but results in less indentation---and would thus be preferred, if not for the 2.4 compatibility issue.

-- 
Karl Wiberg, kha@treskal.com
   subrabbit.wordpress.com
   www.treskal.com/kalle