Re: [PATCH 1/6] stg mail: Refactor __send_message and friends

From: Alex Chiang <achiang@hp.com>
Date: Nov 30, 2009, 23:58 UTC
Message-ID: <20091130235825.GJ12733@ldl.fc.hp.com>
In-Reply-To: <4B123B48.4050405@treskal.com>

* Karl Wiberg <kha@treskal.com>:

Show 9 quoted lines

> Alex Chiang wrote:
>
>> +    if (smtppassword and not smtpuser):
>> +        raise CmdException, 'SMTP password supplied, username needed'
>> +    if (smtpusetls and not smtpuser):
>> +        raise CmdException, 'SMTP over TLS requested, username needed'
>
> Python style nit: Use "raise Exception('message')" in new code. (And
> yes, I know you just moved these lines around.)

Changed, thanks.