[StGit RFC PATCH 0/6] add support for git send-email
- From
- Alex Chiang <achiang@hp.com>
- Date
- Nov 28, 2009, 19:50 UTC
- Message-ID
- <20091128194056.949.88791.stgit@bob.kio>
Hi Catalin,
This series starts down the path of eventually converting stg mail to simply become a wrapper around git send-email.
The first 4 patches do some refactoring of internal APIs to set us up for the money patch 5/6 which actually adds the call to git send-email.
Patch 6/6 shows a hint of the future, where we can start leveraging some of the features in git send-email for our own purposes. With it, you can now use mail aliases as supported by git send-email.
stg mail still has some nice features over git send-email, such as the -v command line parameter and --prefix. Maybe at some point in the future, we can migrate those features into git send-email and continue thinning out stg mail.
But I wanted to get some feedback first to make sure I'm going in the right direction before going too much further.
Disclaimer: I'm not really a python coder. Particularly, patch 5/6 is ugly in how we look at the various stg mail options. I'm sure there's lots of room for improvement.
This mail was sent with: ./stg mail -a --git --auto -e
[Karl, sorry about the earlier accidental mail. That was a testing mishap.]
Thanks, /ac
---
Alex Chiang (6):
stg mail: Refactor __send_message and friends
stg mail: reorder __build_[message|cover] parameters
stg mail: make __send_message do more
stg mail: factor out __update_header
stg mail: add basic support for git send-email
stg mail: don't parse To/Cc/Bcc in --git modestgit/commands/mail.py | 205 ++++++++++++++++++++++++++++-------------------- 1 files changed, 121 insertions(+), 84 deletions(-)