Re: "submodule foreach" much slower than removed "submodule--helper --list"
- From
- Matti Möll <matti.moell@opensynergy.com>
- Date
- Nov 7, 2022, 11:01 UTC
- Message-ID
- <b5017077-720b-3085-39f0-54dc6b6fcaf6@opensynergy.com>
- In-Reply-To
- <xmqqwn904sof.fsf@gitster.g>
On 16.10.22 00:40, Junio C Hamano wrote:
Show 6 quoted lines
> > If one likes the output from "submodule--helper list" so much, I > think your "ls-files" above should be the closest. There seems to > have existed some logic to squash unmerged entries down to a single > one, too (git-submodule.sh in Git 2.0.0 era has a module_list shell > function that shows what "helper list" should be doing), though.
I do actually like that submodule is hoisted out of the scripts but as a matter of fact it seems that the openembedded folks relied on the "submodule--helper list" call and with later git versions that doesn't work anymore.
https://github.com/openembedded/openembedded-core/commit/6d9364e5f3535954f65cbbc694ee7933ac1d664f
At the end of the day it's kinda their fault to depend on the submodule--helper but it does hinder adoption of new git versions for people using openembedded.
Cheers,
Matti