Re: "submodule foreach" much slower than removed "submodule--helper --list"
- From
Jeff King <peff@peff.net>
- Date
- Oct 15, 2022, 18:23 UTC
- Message-ID
- <Y0r6iAv1OVUVYNGc@coredump.intra.peff.net>
- In-Reply-To
- <xmqqilkl54wp.fsf@gitster.g>
On Sat, Oct 15, 2022 at 11:16:06AM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> Jeff King <peff@peff.net> writes: > > > Yeah, that's not too surprising that it's slower. It's exec-ing a bunch > > of shells to do that. > > ... > > I'm not sure if those are exactly equivalent, either. It looks like the > > old code was probably respecting submodule active markers (though in my > > test repo without the submodule actually checked out, it's still > > reported). There is probably room for a user-facing "git submodule list" > > command, but again, I don't really know enough about the space to say > > what it should report. > > We could mimic "find" and make "foreach" that has no action default > to an equivalent of "echo" that is done internally without forking.
That would be reasonable to me, though I wonder what the output format should be. Just name, or name/oid? Once you start having options, you might as well just add a separate "git submodule list" that can take them.
-Peff