Re: "submodule foreach" much slower than removed "submodule--helper --list"

From: Jeff King <peff@peff.net>
Date: Oct 17, 2022, 17:02 UTC
Message-ID: <Y02KtjAUGSPqffvB@coredump.intra.peff.net>
In-Reply-To: <xmqqwn904sof.fsf@gitster.g>

On Sat, Oct 15, 2022 at 03:40:16PM -0700, Junio C Hamano wrote:

Show 5 quoted lines

> If one likes the output from "submodule--helper list" so much, I
> think your "ls-files" above should be the closest.  There seems to
> have existed some logic to squash unmerged entries down to a single
> one, too (git-submodule.sh in Git 2.0.0 era has a module_list shell
> function that shows what "helper list" should be doing), though.

Ah, good digging. I briefly looked at the patch removing the submodule--helper version, saw the word "active", and assumed it was checking that. On closer inspection, it is just the global "active_nr" for iterating over the index. ;)

So yeah, using "ls-files" is a suitable replacement for Jonas's original complaint. I'll leave it up to folks more interested and knowledgeable on submodules to discuss whether there ought to be a listing command that's more aware of gitmodules, populated fields, active flags, etc.

-Peff