Re: [PATCH RFC 3/6] send-email: Handle "GIT:" rather than "GIT: " during --compose

From: Michael Witten <mfwitten@gmail.com>
Date: Apr 12, 2009, 02:36 UTC
Message-ID: <b4087cc50904111936r6cbde773scbe5e7243442dc79@mail.gmail.com>
In-Reply-To: <7v3aced6vr.fsf@gitster.siamese.dyndns.org>

On Sat, Apr 11, 2009 at 19:59, Junio C Hamano <gitster@pobox.com> wrote:

> Special variables like $_ cannot be made into lexicals, unless you know
> you will only run with a very recent version of Perl (5.9.1, I think).

Ah. I wish Perl's docs were a little more forthcoming about such things. I ended up just trying it out, and indeed I am running 5.10.0.

Show 10 quoted lines

> If you do not want to worry about portability, typically it is easiest to
> say "local ($_)" upfront in the beginning of a sub.
>
> I do not understand why you want to change the original
>
>        while (my $line = <$fh>) {
>                ...
>        }
>
> though.

I'm not terribly bent on it; I had already reshaped that function and I was curious about making what I had done work out of intellectual curiosity. In fact, my commits no longer have the refactored version.