Re: [PATCH RFC 2/6] send-email: --smtp-server-port should take an integer

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 11, 2009, 19:22 UTC
Message-ID: <7vvdpbf11m.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1239139522-24118-2-git-send-email-mfwitten@gmail.com>

Michael Witten <mfwitten@gmail.com> writes:

Show 18 quoted lines

> Signed-off-by: Michael Witten <mfwitten@gmail.com>
> ---
>  git-send-email.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 273c8c7..63d6063 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -251,7 +251,7 @@ my $rc = GetOptions("sender|from=s" => \$sender,
>  		    "chain-reply-to!" => \$chain_reply_to,
>  		    "delay=i" => \$delay,
>  		    "smtp-server=s" => \$smtp_server,
> -		    "smtp-server-port=s" => \$smtp_server_port,
> +		    "smtp-server-port=i" => \$smtp_server_port,
>  		    "smtp-user=s" => \$smtp_authuser,
>  		    "smtp-pass:s" => \$smtp_authpass,
>  		    "smtp-ssl" => sub { $smtp_encryption = 'ssl' },

Hmm, I have to wonder if there somebody who is using symbolic names for ports, e.g. --smtp-server-port=ssmtp which this patch may start rejecting.