Re: [PATCH RFC 4/6] send-email: --compose takes optional argument to existing file

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 11, 2009, 19:22 UTC
Message-ID: <7vk55rf11c.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1239139522-24118-4-git-send-email-mfwitten@gmail.com>

Michael Witten <mfwitten@gmail.com> writes:

Show 22 quoted lines

> Now, a user may specify an existing (in-progress) file to use as
> the introductory/summary email.
>
> The file is opened for any additional editing as usual.
>
> Signed-off-by: Michael Witten <mfwitten@gmail.com>
> ---
>  Documentation/git-send-email.txt |    7 ++-
>  git-send-email.perl              |  112 ++++++++++++++++++++++----------------
>  2 files changed, 71 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index 4b656ca..bc9ff13 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -57,8 +57,11 @@ The --cc option must be repeated for each user you want on the cc list.
>  	or one for all of them at once.
>  
>  --compose::
> -	Use $GIT_EDITOR, core.editor, $VISUAL, or $EDITOR to edit an
> -	introductory message for the patch series.
> +	Use $GIT_EDITOR, core.editor, $VISUAL, or $EDITOR, or vi to edit an

I think addition of ", or vi" makes sense but the ", or $EDITOR" needs to change, and also the language needs to be clarified to say the first one of these is used.

The name of the new variable $compose_file that is used as a filehandle was confusing to read (almost everybody else in the program uses $fh, and it looked as if $compose_file is talking about the name of the file or indirectly pointing at an existing filehandle, but it was not).