Re: [PATCH v3 00/20] Introduce `USE_THE_REPOSITORY_VARIABLE` macro

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jun 18, 2024, 09:56 UTC
Message-ID: <b2a783cc-ad34-4647-a388-33f75b3122bd@gmail.com>
In-Reply-To: <cover.1718347699.git.ps@pks.im>

Hi Patrick

On 14/06/2024 07:49, Patrick Steinhardt wrote:

Show 11 quoted lines

> Changes compared to v2:
> 
>    - Note in a commit message that we aim to have a faithful conversion
>      when introducing a `struct git_hash_algo` parameter to functions. So
>      even in case the calling context has a `struct git_hash_algo`
>      available via a local repository, we still use `the_repository` such
>      that there cannot be a change in behaviour here. Fixing those sites
>      will be left for a future patch series such that we can avoid any
>      kind of regressions caused by this comparatively large refactoring.
>      I also adapted some conversions to fully follow through with this
>      intent.

Thanks for clarifying that in the commit message of Patch 2.

Best Wishes

Phillip