Re: [PATCH v3 09/20] global: introduce `USE_THE_REPOSITORY_VARIABLE` macro
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 18, 2024, 05:16 UTC
- Message-ID
- <ZnEYNzLue3OIK-Ul@framework>
- In-Reply-To
- <CAOLa=ZTq+sQAtSiQm9xmdLyn=T=u8Ck0oXEBFLnJvH+54O+AHA@mail.gmail.com>
On Mon, Jun 17, 2024 at 05:30:31AM -0400, Karthik Nayak wrote:
Show 14 quoted lines
> Patrick Steinhardt <ps@pks.im> writes: > > diff --git a/hash.h b/hash.h > > index 39a0164be3..cb85d26a2f 100644 > > --- a/hash.h > > +++ b/hash.h > > @@ -4,6 +4,8 @@ > > #include "hash-ll.h" > > #include "repository.h" > > > > -#define the_hash_algo the_repository->hash_algo > > +#ifdef USE_THE_REPOSITORY_VARIABLE > > +# define the_hash_algo the_repository->hash_algo > > s/# define/#define/
This is in fact intentional. We aren't strictly following this in our codebase, but when nesting preprocessor macros into ifdefs then we often indent the inner macros with spaces.
Patrick