Re: [PATCH v2 00/20] Introduce `USE_THE_REPOSITORY_VARIABLE` macro

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Jun 13, 2024, 23:55 UTC
Message-ID: <9d085d3f-5fdf-4a28-b31c-458ba68ebcd4@ramsayjones.plus.com>
In-Reply-To: <CAPc5daUpzc+FDTH4-ajjf6ctnchE5Z6mHVvpm0qnbPLup18ykg@mail.gmail.com>

On 14/06/2024 00:18, Junio C Hamano wrote:

Show 9 quoted lines

> On Thu, Jun 13, 2024 at 4:15 PM Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>>
>> Hmm, odd; isn't the declaration of 'the_repository' from
>> the "repository.h" header file visible at this point?
> 
> No. The declaration is guarded with USE_THE_REPOSITORY_VARIABLE CPP macro
> in the header, and repository.c does not define it.
>

Ah, OK. I haven't been following too closely and didn't notice that the declaration in the header file was now conditional. :(

But that does beg the question - why is repository.c not defining the USE_THE_REPOSITORY_VARIABLE?

ATB, Ramsay Jones

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.