Re: [StGit PATCH 5/9] Convert 'hide' to the lib infrastructure
2009/4/29 Karl Hasselström <kha@treskal.com>:
Show 12 quoted lines
> On 2009-04-28 16:10:03 +0100, Catalin Marinas wrote:
>
>> -args = [argparse.patch_range(argparse.applied_patches,
>> - argparse.unapplied_patches)]
>> +args = [argparse.patch_range(argparse.unapplied_patches)]
>
> Why not simply allow all patches? reorder_patches() below will happily
> pop unapplied patches before hiding them IIRC, and for already hidden
> patches you could just say "already hidden".
>
> Hmm, but this is for the tab completion, so I guess we'd only want the
> applied and unapplied patches here.
I fixed that in the proposed branch but I was to slow on sending e-mails.
Show 6 quoted lines
> As I said,
>
> * Why not simply allow hiding of applied patches?
>
> * Hiding a hidden patch should probably be a warning (if that), not
> an error.
--
Catalin