From: Catalin Marinas Date: Wed, 13 May 2009 16:08:02 GMT Subject: Re: [StGit PATCH 5/9] Convert 'hide' to the lib infrastructure Message-ID: In-Reply-To: <20090429062749.GE18483@diana.vm.bytemark.co.uk> 2009/4/29 Karl Hasselström : > On 2009-04-28 16:10:03 +0100, Catalin Marinas wrote: > >> -args = [argparse.patch_range(argparse.applied_patches, >> -                             argparse.unapplied_patches)] >> +args = [argparse.patch_range(argparse.unapplied_patches)] > > Why not simply allow all patches? reorder_patches() below will happily > pop unapplied patches before hiding them IIRC, and for already hidden > patches you could just say "already hidden". > > Hmm, but this is for the tab completion, so I guess we'd only want the > applied and unapplied patches here. I fixed that in the proposed branch but I was to slow on sending e-mails. > As I said, > >  * Why not simply allow hiding of applied patches? > >  * Hiding a hidden patch should probably be a warning (if that), not >    an error. Fixed this as well. -- Catalin