Re: [StGit PATCH 4/9] Convert 'clone' to the use stgit.lib

From: Karl Hasselström <kha@treskal.com>
Date: Apr 29, 2009, 06:21 UTC
Message-ID: <20090429062101.GD18483@diana.vm.bytemark.co.uk>
In-Reply-To: <20090428150957.27261.83658.stgit@pc1117.cambridge.arm.com>

On 2009-04-28 16:09:57 +0100, Catalin Marinas wrote:

> The patch also adds the stgit.lib.git.clone() function.

Show 5 quoted lines

>      if os.path.exists(local_dir):
> -        raise CmdException, '"%s" exists. Remove it first' % local_dir
> -
> -    print 'Cloning "%s" into "%s"...' % (repository, local_dir)
> +        raise common.CmdException, '"%s" exists. Remove it first' % local_dir

As recommended by PEP 8, consider using the "raise Exc(args)" syntax:

    - When raising an exception, use "raise ValueError('message')" instead of
      the older form "raise ValueError, 'message'".

      The paren-using form is preferred because when the exception arguments
      are long or include string formatting, you don't need to use line
      continuation characters thanks to the containing parentheses.  The older
      form will be removed in Python 3000.

> +def clone(remote, local):
> +    """Clone a remote repository using 'git clone'."""
> +    run.Run('git', 'clone', remote, local).run()

You don't capture git's output here, but just let it through. Does that look good in combination with the enclosing out.start() ... .done() stuff?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle