git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly

From
CMCatalin Marinas <catalin.marinas@gmail.com>
Date
Sep 5, 2008, 21:35 UTC
Message-ID
<b0943d9e0809051435g23fa3b83u2a1e8f2a3a6b955f@mail.gmail.com>
In-Reply-To
<20080903162123.GA874@diana.vm.bytemark.co.uk>
2008/9/3 Karl Hasselström <kha@treskal.com>:
Show 8 quoted lines
> On 2008-09-04 00:47:17 +0900, Shinya Kuribayashi wrote:
>
>> diffcol.sh is based on Quilt, and Quilt is dependent on bash;
>> Actually all Quilt scripts use /bin/bash without exceptions. Then
>> it's good for diffcol.sh to use /bin/bash.
>
> Thanks for this, and the other patch you sent. I'll be picking them up
> this weekend, unless Catalin beats me to it.

BTW, I think at some point we could change to using Git's native colouring. The diffcol.sh script is from the days when Git didn't have this feature. We currently generate a diff string and pass it through the pager but I'm not sure how to do this.

-- 
Catalin
Previous: Karl Hasselström
Message 3 of 3 in “diffcol.sh: Use /bin/bash explicitly”
  1. diffcol.sh: Use /bin/bash explicitlyShinya Kuribayashi, Sep 3, 2008
  2. Karl HasselströmSep 3, 2008
  3. Catalin MarinasSep 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.