git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGIT PATCH] diffcol.sh: Use /bin/bash explicitly

From
SKShinya Kuribayashi <skuribay@ruby.dti.ne.jp>
Date
Sep 3, 2008, 15:47 UTC
Message-ID
<48BEB185.2080505@ruby.dti.ne.jp>

Recent Ubuntu uses dash (Debian Almquist Shell; a lightweight POSIX- compliant shell derived from ash) as /bin/sh by default. In this case pager=diffcol.sh doesn't work like this:

> skuribay@ubuntu:~/kernel/linux.git$ stg show
> /home/skuribay/share/stgit/contrib/diffcol.sh: 22: Bad substitution
this is caused by non-bash-compliant /bin/sh.

diffcol.sh is based on Quilt, and Quilt is dependent on bash; Actually all Quilt scripts use /bin/bash without exceptions. Then it's good for diffcol.sh to use /bin/bash.

Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
---
 contrib/diffcol.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/diffcol.sh b/contrib/diffcol.sh
index ea9109d..eecc87a 100755
--- a/contrib/diffcol.sh
+++ b/contrib/diffcol.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 
 # Code copied from Quilt (http://savannah.nongnu.org/projects/quilt)
 #
Next: Karl Hasselström
Message 1 of 3 in “diffcol.sh: Use /bin/bash explicitly”
  1. diffcol.sh: Use /bin/bash explicitlyShinya Kuribayashi, Sep 3, 2008
  2. Karl HasselströmSep 3, 2008
  3. Catalin MarinasSep 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.